Few things

[Hoplite]

- First one isn't really a bug as such, but it'd be nice to have more notifications about the place.  For example, when trying to select the Dodge as a police officer, it should tell you if you're not eligible (I assume that it's for a certain rank) and that you've been issued the standard vehicle instead.

- This probably happens with other items, but the one I discovered it was with a fishing rod.  I tried to equip it as an officer, and it told me only citizens could equip this.  All well and good... if it didn't permanently take the item away from me!

- Vehicle scripts.  They're pretty poor, and could do with a good going over.  Steering angles on some are way too over the top, others are ridiculously large.  They handle fairly jankily, and some vehicles like to skid.  This could be to do with the tyre materials, torque, or a few other variables in the respective vehicle_script.txt.

- Vehicle passenger positions!  As above, could do with a good going over.  The fire engine for example, any passenger in that cannot go into third person, or even see anything (they're stuck inside a seat mesh)!

- Once again, kind of a suggestion, but considering I'm chucking a few things in here, why not.  There should be a few more abbreviations for chat commands.  [[ or .// for LOOC, /r for radio.  Considering this was a suggestion, I'll mix it in with a bug.  In the console, the players OOC name is printed when they're talking IC, instead of their IC name.

- /it shouldn't really have the players name [Lucy Wright (IT)  <msg>] infront of it.  It looks better if it's something like... [** <msg >**].  It would also be nice if for /me, you could do /me's without it displaying: Lucy Wright 's <msg>.

- Finally, word wrapping!  Sometimes I like to type longer than one line of text, it shouldn't cut me off or give me a really jarring beep when I've put too much in (which isn't even that much at all)!

E: Few more things!
- The speedometer is very glitchy!  It's not smooth when it shows your speed, and likes to leap up and jitter about.

- Some resources aren't on the server, mostly GUI assets.  For example:


- The chatbox leaks some text, or rather, isn't properly scaled.  This is 1920x1080 resolution, and as you can see some of the text can be seen that should be hidden.  Perhaps scale down the font size, also?


- Road spikes also don't seem to place.  I right clicked them and they just disappeared from my inventory!

- When exiting a vehicle, headlights will stay on.  This is cool, but when you unlock a car that has it's lights on, they don't keep their state, and turn off again!  Not always replicable.  Sirens also seem to toggle the headlights?

- Exiting the vehicle can very easily make you stuck.  Perhaps you should draw a trace out, and work from there to prevent that from happening.

[garry :D]

- Vehicle scripts.  They're pretty poor, and could do with a good going over.  Steering angles on some are way too over the top, others are ridiculously large.  They handle fairly jankily, and some vehicles like to skid.  This could be to do with the tyre materials, torque, or a few other variables in the respective vehicle_script.txt.

The Police Charger has been fixed for the most part after testing it in the development server. If Crap Head gives me the green light then I'll try and improve the others to have more latency-friendly steering. In the Pol Charger's case it was just that the torque was too high and that the suspension wasn't balanced/stiff enough so it slipped over the road.

[Hoplite]

Good to know!

Also, as a sidenote, I'd be happy to help out if you guys are cool with it.  Lua is fun!





(lol.)

[Hoplite]

A few more things!

- "Fixed the rest of the silkicons being purple and black."


- "Body armor no longer shows up on secret service agents. They still have it though."


- The chat commands (assuming all) don't have any utilisation of string.lower!  /radiO for example will not work as a command.

- You're subbing text in a weird way to remove the commands also, all parts of a command will be removed from the returned string.  For example, "//a//" -> "a".

- Missing some sounds in content.
    " Failed to load sound "vehicles\tdmcars\tires\1.mp3", file probably missing from disk/repository
    Failed to load sound "vehicles\tdmcars\tires\3.mp3", file probably missing from disk/repository
    Failed to load sound "vehicles\tdmcars\tires\2.mp3", file probably missing from disk/repository
    Failed to load sound "cg_ocrp2\ocrp2_message_received.mp3", file probably missing from disk/repository"

- Players can exploit the player colour changing, you're not clamping the values, so players can have their colour set to something like this:


- Players can exploit the phone and send messages with a name that isn't there own, because you don't check for that.  ocrp2_sendmessage "this isnt my name!!!" "Lucy Wright" "wtf omg xd protection!"


- More missing content!  Some (shelby, caterham, ATV) of the previews on the little boxes for vehicles are errors!


- You're the mayor, huh?  Don't wanna select either of the options on that event, you say? Well then, just type in "OCRP2_CloseMenus" to your console, and be care-free!

- Text formatting!


- Upon using the librarian:
    "[ERROR] gamemodes/ocrp2/gamemode/client/vgui/shops.lua:379: attempt to index a nil value
  1. GUI_Rebuild_Shop_Items - gamemodes/ocrp2/gamemode/client/vgui/shops.lua:379
   2. GUI_ShopMenu - gamemodes/ocrp2/gamemode/client/vgui/shops.lua:133
    3. Function - gamemodes/ocrp2/gamemode/client/vgui/npc_talk.lua:10
     4. unknown - lua/includes/modules/usermessage.lua:87"

[Crap-Head]

- First one isn't really a bug as such, but it'd be nice to have more notifications about the place.  For example, when trying to select the Dodge as a police officer, it should tell you if you're not eligible (I assume that it's for a certain rank) and that you've been issued the standard vehicle instead.
Done.

- This probably happens with other items, but the one I discovered it was with a fishing rod.  I tried to equip it as an officer, and it told me only citizens could equip this.  All well and good... if it didn't permanently take the item away from me!
This was fixed in the last patch.

- Vehicle scripts.  They're pretty poor, and could do with a good going over.  Steering angles on some are way too over the top, others are ridiculously large.  They handle fairly jankily, and some vehicles like to skid.  This could be to do with the tyre materials, torque, or a few other variables in the respective vehicle_script.txt.
OzJackal is working on the vehicles script. They will improve over time.

- Vehicle passenger positions!  As above, could do with a good going over.  The fire engine for example, any passenger in that cannot go into third person, or even see anything (they're stuck inside a seat mesh)!
Well, some seat positions are really bad, and i know about that. Would be nice with a full list, so i could do them all at once. Tho passenger seats was never able to go into third person?

- Once again, kind of a suggestion, but considering I'm chucking a few things in here, why not.  There should be a few more abbreviations for chat commands.  [[ or .// for LOOC, /r for radio.  Considering this was a suggestion, I'll mix it in with a bug.  In the console, the players OOC name is printed when they're talking IC, instead of their IC name.
Added. You still have put the / to begin using commands tho.

- /it shouldn't really have the players name [Lucy Wright (IT)  <msg>] infront of it.  It looks better if it's something like... [** <msg >**].  It would also be nice if for /me, you could do /me's without it displaying: Lucy Wright 's <msg>.
Not a bug.

- Finally, word wrapping!  Sometimes I like to type longer than one line of text, it shouldn't cut me off or give me a really jarring beep when I've put too much in (which isn't even that much at all)!
Khub will add word wrapping when he has time. He has a script from HL2RP.

E: Few more things!
- The speedometer is very glitchy!  It's not smooth when it shows your speed, and likes to leap up and jitter about.
Not sure about this? Think you could post another bug report and explain it a bit more?

- Some resources aren't on the server, mostly GUI assets.  For example:

Fixed in the next patch.

- The chatbox leaks some text, or rather, isn't properly scaled.  This is 1920x1080 resolution, and as you can see some of the text can be seen that should be hidden.  Perhaps scale down the font size, also?


- Road spikes also don't seem to place.  I right clicked them and they just disappeared from my inventory!

- When exiting a vehicle, headlights will stay on.  This is cool, but when you unlock a car that has it's lights on, they don't keep their state, and turn off again!  Not always replicable.  Sirens also seem to toggle the headlights?
I was not able to recreate this?

- Exiting the vehicle can very easily make you stuck.  Perhaps you should draw a trace out, and work from there to prevent that from happening.
Tom added a trace script in the last update. Can't always count on it tho.

Post #2

A few more things!

- "Fixed the rest of the silkicons being purple and black."

Fixed in the next patch.

- "Body armor no longer shows up on secret service agents. They still have it though."

Fixed in the next patch.

- The chat commands (assuming all) don't have any utilisation of string.lower!  /radiO for example will not work as a command.
Fixed in the next patch.

- You're subbing text in a weird way to remove the commands also, all parts of a command will be removed from the returned string.  For example, "//a//" -> "a".
Fixed in the next patch.

- Missing some sounds in content.
    " Failed to load sound "vehicles\tdmcars\tires\1.mp3", file probably missing from disk/repository
    Failed to load sound "vehicles\tdmcars\tires\3.mp3", file probably missing from disk/repository
    Failed to load sound "vehicles\tdmcars\tires\2.mp3", file probably missing from disk/repository
    Failed to load sound "cg_ocrp2\ocrp2_message_received.mp3", file probably missing from disk/repository"
Fixed in the next patch.

- Players can exploit the player colour changing, you're not clamping the values, so players can have their colour set to something like this:

Fixed in the next patch.

- Players can exploit the phone and send messages with a name that isn't there own, because you don't check for that.  ocrp2_sendmessage "this isnt my name!!!" "Lucy Wright" "wtf omg xd protection!"

Fixed in the next patch.

- More missing content!  Some (shelby, caterham, ATV) of the previews on the little boxes for vehicles are errors!

I believe this has something to do with how rendering icons work. I am not sure how to fix this. The spawn icon there, and the model preview that spins, are all grabbed from the same table. The same table that defines the model when the car is spawned. So it's not because you are actually missing the model.

- You're the mayor, huh?  Don't wanna select either of the options on that event, you say? Well then, just type in "OCRP2_CloseMenus" to your console, and be care-free!
Fixed in the next patch.

- Text formatting!

Will cut that down.

- Upon using the librarian:
    "[ERROR] gamemodes/ocrp2/gamemode/client/vgui/shops.lua:379: attempt to index a nil value
  1. GUI_Rebuild_Shop_Items - gamemodes/ocrp2/gamemode/client/vgui/shops.lua:379
   2. GUI_ShopMenu - gamemodes/ocrp2/gamemode/client/vgui/shops.lua:133
    3. Function - gamemodes/ocrp2/gamemode/client/vgui/npc_talk.lua:10
     4. unknown - lua/includes/modules/usermessage.lua:87"
Fixed in the next patch.

Thanks for the very detailed post, and bug reports. The second post was really good, and it was really easy for me to fix the issues fast.

Locked.